Feat: Support Graphql subscription via websocket[INS-4390] #7990
Conversation
cwangsmv
force-pushed
the
feat/graph-subscription-support
branch
from
70cb07c to
bde59c0
Compare
cwangsmv
force-pushed
the
feat/graph-subscription-support
branch
from
72ae829 to
742ecec
Compare
jackkav
left a comment
jackkav
left a comment
There was a problem hiding this comment.
Curious the see how persistent the connection is. What if you navigate to another workspace and back? Or open a second instance of insomnia.
| const { url, method } = activeRequest; | ||
| const isEventStreamOpen = useReadyState({ requestId: activeRequest._id, protocol: 'curl' }); | ||
| const isCancellable = currentInterval || currentTimeout || isEventStreamOpen; | ||
| const isGraphQLSubscriptionOpen = useReadyState({ requestId: activeRequest._id, protocol: 'webSocket' }); |
There was a problem hiding this comment.
I'm a bit tempted to try to merge the action-bar.tsx into this one as its mostly copypasta and this is the only important line in that component.
There was a problem hiding this comment.
Agree, so both normal request and websocket request could use request-url-bar.tsx
There was a problem hiding this comment.
Can scope it out of this PR though.
jackkav
left a comment
jackkav
left a comment
There was a problem hiding this comment.
really elegant implementation
It's a reuse of the current websocket connection logic so it will have the same behavior. Current when nav to another workspace and back, the connection will be closed |
packages/insomnia/package.json
Outdated
| "graphql-ws": "^5.16.0", | ||
| "graphql": "^16.8.1" |
There was a problem hiding this comment.
running npm i -w insomnia -S graphql-ws will fix this ordering issue
cwangsmv
force-pushed
the
feat/graph-subscription-support
branch
from
0335289 to
5e194b2
Compare
Changes:
graphql-subscription.mp4
Closes #6055