Conversation
yaoweiprc
changed the title
gatzjames
approved these changes
Sep 24, 2024
Contributor
gatzjames
left a comment
gatzjames
left a comment
There was a problem hiding this comment.
This is much simpler than the useEffect approach but some things to keep in mind:
- It will create sync issues if we do async stuff that then need to update state
- We should upgrade this to an action with the new react router v7 version
- We should hold back from doing the same thing on other actions since it will create a lot of tech debt
Free user can either have one project with multiple members or have multiple project with one member. So if you are a free user and only have one project. You invite someone to your project. Then you create a new project. An Alert of 'Could not create project' shows. Then you remove the other member from your project. You can successfully create a new project. But when you switch to the previous project, the alert shows again.
gatzjames
force-pushed
the
fix/upgrade-plan-prompt
branch
from
d946080 to
e722954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free user can either have one project with multiple members or have multiple project with one member. So if you are a free user and only have one project. You invite someone to your project. Then you create a new project. An Alert of 'Could not create project' shows. Then you remove the other member from your project. You can successfully create a new project. But when you switch to the previous project, the alert shows again.
It's introduced by react router's data router, which persists fetch.data.