Skip to content

feat: enable run folder mode#8004

Merged
ihexxa merged 2 commits intodevelopfrom
feat/folder-runner
Oct 11, 2024
Merged

feat: enable run folder mode#8004
ihexxa merged 2 commits intodevelopfrom
feat/folder-runner

Conversation

@ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Sep 25, 2024

Background

Make the runner support "Run folder" capability.

Changes

  • Filtering requests according to the target (collection or folder)
image

Ref: INS-4473

@ihexxa ihexxa self-assigned this Sep 25, 2024
@ihexxa ihexxa marked this pull request as draft September 25, 2024 06:11
@ihexxa ihexxa force-pushed the feat/folder-runner branch 3 times, most recently from 0785f69 to f941d96 Compare October 10, 2024 02:05
@ihexxa ihexxa marked this pull request as ready for review October 10, 2024 02:07
@ihexxa ihexxa requested a review from a team October 10, 2024 02:07
Copy link
Contributor

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Small improvements/suggestion:

  • Don't hide the Collection Run button when in collection run view in case i want to go from collection run view of my folder into the one for the entire workspace
  • If user opens collection run for a folder - automatically "Select All" requests, otherwise I have to 1. open collection run for folder, 2. select all requests and 3. only then can I run

Alternate idea:

  • Run folder would still open the same workspace collection run - and just pre-select all requests & folders under the folder selected

@ihexxa
Copy link
Contributor Author

ihexxa commented Oct 11, 2024

@filfreire Good ideas.

@ihexxa ihexxa force-pushed the feat/folder-runner branch from f941d96 to 77d524c Compare October 11, 2024 09:23
@ihexxa ihexxa enabled auto-merge (squash) October 11, 2024 09:23
@ihexxa ihexxa merged commit 08dd01d into develop Oct 11, 2024
@ihexxa ihexxa deleted the feat/folder-runner branch October 11, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants