fix: disable request error modal - [INS-4559]#8068
Merged
CurryYangxx merged 4 commits intodevelopfrom Oct 12, 2024
Merged
Conversation
CurryYangxx
force-pushed
the
fix/request-error-modal
branch
from
188ca27 to
e66e130
Compare
CurryYangxx
commented
Oct 12, 2024
| } | ||
| // this part is for persisting useful info (e.g. timeline) for debugging, even there is an error | ||
| const existingResponse = await models.response.getById(err.response._id); | ||
| const response = existingResponse || await models.response.create(err.response, err.maxHistoryResponses); |
Member
Author
There was a problem hiding this comment.
we store error responses in this catch callback
ihexxa
approved these changes
Oct 12, 2024
CurryYangxx
force-pushed
the
fix/request-error-modal
branch
from
93c73b3 to
0f67417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close INS-4559
Changes: