fix(cli): ca and certs are not included in loading db from CLI#8111
Conversation
ihexxa
changed the title
ihexxa
changed the title
|
Let me take a look and cover it, originally it was a quick fix but as more changes will be introduced, setting it to draft. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Added tests with fake db, certs. The cert test will load the fake cert although it will finally fail, which should be ok. |
| @@ -0,0 +1 @@ | |||
| fake key content | |||
There was a problem hiding this comment.
for a future PR pass I recommend we also try with a working cert
There was a problem hiding this comment.
+1 originally I added one but the key was blamed by the github bot above, probably we could try with cert. 🥹
There was a problem hiding this comment.
Can't you ignore the GitHub bot? A happy test is more valuable than a sad one.
| console.log(result); | ||
| } | ||
| expect(result.stdout).toContain('Adding SSL PEM certificate'); | ||
| expect(result.stdout).toContain('Adding SSL KEY certificate'); |
|
It's easier to fix this test later if you isolate the case using a yml input rather than nedb one and would fit the convention of the other tests in this group you're adding to. |
|
@jackkav I agree with your points about testing tls connection and tests with yml, as this PR mainly focuses on fixing data loading so I propose to extend it in the next. |
5 participants
Changes
Ref: INS-4598