fix(cli): enable setNextRequest for CLI#8143
Merged
Conversation
ihexxa
force-pushed
the
feat/cli/set-next-request
branch
3 times, most recently
from
140905f to
73165bf
Compare
ihexxa
force-pushed
the
feat/cli/set-next-request
branch
from
73165bf to
d40b2f8
Compare
cwangsmv
approved these changes
Nov 7, 2024
Contributor
cwangsmv
left a comment
cwangsmv
left a comment
There was a problem hiding this comment.
Test different setNextRequest situation and LGTM
ihexxa
force-pushed
the
feat/cli/set-next-request
branch
from
d40b2f8 to
5f0a0bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This change basically tries to keep most of the changes from the proposed solution although some work might still be required to make the solution more comprehensive. Therefore this PR tries to make minimal changes to enable
setNextRequestin CLI and also keep tests and enhancements from the proposed solution.Changes
setNextRequestfor CLIRef: INS-4604