feat: multiple tabs - [INS-4225]#8151
Conversation
ada3f7a to
ca2d22b
Compare
a8d050d to
68c7cdf
Compare
filfreire
left a comment
There was a problem hiding this comment.
LGTM
Found issue where tabs disappear when pressing OPTION + TAB in the UI after a few times
some suggestions for this PR or other follow-up PRs:
- allow for pressing CTRL + TAB / CTRL + SHIFT + TAB to alternate between tabs
- perhaps also allow the same for pressing CTRL + 1 (1 to 9) to go to 1st -> 9th tab, 0 being last tab?
- allow middle-mouse click to close a tab
- capture COMMAND+W (and windows/linux equivalent) to close tabs
96e019e to
8426d96
Compare
7e30c69 to
34e0e5f
Compare
6eab9eb to
f802655
Compare
|
it would be nice capture COMMAND+W (and windows/linux equivalent) to close tabs |
19d1d13
2807dd5 to
b9117cf
Compare
|
Update: (5e90726)
|
8e57033 to
89ae88e
Compare
|
@CurryYangxx, I took a pass at the branch again and tried after your commit and seems copying and moving seems to be working. I noticed one other thing - for example if you have 2 tabs open for 2 requests, and maybe you are working on pre-request/after-response scripts, or docs, or headers.... etc. in both, the moment you switch tabs, you are not redirected to the "sub-tab" you were at when browsing the request. So each time we switch between tabs we don't remember where inside the tab specifically the user was. |
f431f46 to
b93f004
Compare
* runner improvements * runner improvement * maintain runner state in context * fix lint * save file object to context * add request list to runner context to keep order * fix ts error * add eventbus & clear runner context state * also delete folder runner tab when delete a folder * clean * change runner context data structure * clean up
* fix: runner not update * also delete folder runner tab when delete a folder * fix: keep websocket connection * feat: keep grpc&websocket connection * unify close connection after tab closed * del repeat func * close graphql subscription * resolve conflict * feat: close connections when active environment change * add desc for hooks * close connections when organization change
* test: multiple tab * fix: dashboard test
c7af264 to
a3128f4
Compare

Changes
TabListandTabComponent, and import it in every type of file page.InsomniaTabContextto manage state of the tabsuseInsomniaTabhookshow-context-menutoshow-nunjucks-context-menushow-context-menuas the common context menu methodrelated to #6108