Skip to content

Conversation

@ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Nov 8, 2024

Background

When insomnia.variables.set sets a variable, the variable should exist during whole runner execution period. Currently it is dropped after requesting.

Changes

  • Wired up predefined local variables from runner to script runtime
  • Input local variables to the rendering step
  • Added and updated tests

Ref: INS-4665, #8148

@ihexxa ihexxa self-assigned this Nov 8, 2024
@ihexxa ihexxa changed the title fix(runner): extend insomnia.variables.set effect to whole execution period fix(runner): extend insomnia.variables.set lifetime to whole execution period Nov 8, 2024
@ihexxa ihexxa force-pushed the fix/runner/transient-vars branch from 39b3d7d to ab546cf Compare November 12, 2024 09:03
@ihexxa ihexxa force-pushed the fix/runner/transient-vars branch from ab546cf to 7415263 Compare November 13, 2024 09:07
Copy link
Contributor

@yaoweiprc yaoweiprc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ihexxa ihexxa merged commit 8fad120 into develop Nov 13, 2024
@ihexxa ihexxa deleted the fix/runner/transient-vars branch November 13, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants