Skip to content

fix(cli): insomnia.variables.set should persist variables during runner execution period#8172

Merged
ihexxa merged 3 commits into
developfrom
fix/cli/transient-vars
Nov 15, 2024
Merged

fix(cli): insomnia.variables.set should persist variables during runner execution period#8172
ihexxa merged 3 commits into
developfrom
fix/cli/transient-vars

Conversation

@ihexxa

@ihexxa ihexxa commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

This change focuses on CLI.

Changes

  • Init transient variables in CLI runner
  • Wire transient variables up to the sendRequest and scriptExecutor

Ref: #8148, INS-4647

@ihexxa ihexxa self-assigned this Nov 14, 2024
@ihexxa
ihexxa marked this pull request as draft November 14, 2024 08:10
@cwangsmv
cwangsmv self-requested a review November 15, 2024 01:38
@ihexxa
ihexxa marked this pull request as ready for review November 15, 2024 03:08

@cwangsmv cwangsmv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test local variables across different requests in the same runner and it works as expected

@ihexxa
ihexxa merged commit 695d778 into develop Nov 15, 2024
@ihexxa
ihexxa deleted the fix/cli/transient-vars branch November 15, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants