Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change header placeholder from My-Header to Header so it says New Header #820

Merged
merged 1 commit into from Mar 19, 2018

Conversation

@benatkin
Copy link
Contributor

benatkin commented Mar 17, 2018

When I create a header, it has "New My-Header" for the placeholder:

screen shot 2018-03-17 at 1 09 49 am

This is a bit redundant. I think "My-Header" or "New Header" would both be good, but since the value is "New Value", I think it makes sense to change it to "New Header". Here's what it looks like after the change in this PR:

screen shot 2018-03-17 at 1 10 04 am

@welcome

This comment has been minimized.

Copy link

welcome bot commented Mar 17, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Mar 19, 2018

Awesome. Small but valuable change 😄

Thanks @benatkin!

@gschier gschier merged commit d05ca85 into Kong:develop Mar 19, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Mar 19, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.