Insomnia Format v5#8209
Merged
gatzjames merged 30 commits intoKong:developfrom Feb 18, 2025
Merged
Conversation
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
cb41723 to
b24bbe8
Compare
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
b24bbe8 to
2ec7d17
Compare
yaoweiprc
reviewed
Dec 10, 2024
| "yaml-source-map": "^2.1.1" | ||
| "yaml-source-map": "^2.1.1", | ||
| "zod": "^3.23.8", | ||
| "zod-to-json-schema": "^3.23.3" |
Contributor
There was a problem hiding this comment.
It seems that zod-to-json-schema is not used.
yaoweiprc
reviewed
Dec 10, 2024
|
|
||
| const apiSpecSchema = z.object({ | ||
| type: z.literal('spec.insomnia.rest/5.0'), | ||
| meta: MetaSchema.optional(), |
Contributor
There was a problem hiding this comment.
Can use zod extend method to remove duplicate codes.
yaoweiprc
reviewed
Dec 11, 2024
| resources.push(requestGroup); | ||
|
|
||
| walkCollection(item.children, requestGroup._id); | ||
| } else if ('method' in item) { |
Contributor
There was a problem hiding this comment.
I think that we need a type field to identity what entity it is.
yaoweiprc
reviewed
Dec 11, 2024
| function getCollectionFromResources(resources: (Request | RequestGroup | WebSocketRequest | GrpcRequest)[], parentId: string): Extract<InsomniaFile, { type: 'collection.insomnia.rest/5.0' }>['collection'] { | ||
| const collection: Extract<InsomniaFile, { type: 'collection.insomnia.rest/5.0' }>['collection'] = []; | ||
|
|
||
| resources.filter(resource => resource.parentId === parentId).forEach(resource => { |
Contributor
There was a problem hiding this comment.
Can build the tree in O(n) time.
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
3 times, most recently
from
d9a32a4 to
6124ada
Compare
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
a8e67bf to
dceb1c3
Compare
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
767dadc to
4bb0640
Compare
Contributor
|
I think we should leave some breadcrumbs here about what The new schema looks a little more human readable than the older version. I think this PR should list future work. Examples might include:
|
jackkav
previously approved these changes
Jan 22, 2025
Contributor
|
If theres anything you can do make the parsing code any simpler it would be welcome, and perhaps a comment in the import ingestion code indicating the work that still needs to be done to untangle the brute force import mechanism. Both can be scoped out too. |
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
0d4b434 to
3fa7745
Compare
jackkav
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
3fa7745 to
3ecf3f2
Compare
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
22a8b8d to
91fb97a
Compare
jackkav
approved these changes
Feb 18, 2025
gatzjames
deleted the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploring the new v5 format:
schema.tsto something better e.g.v5-schema-parser.tsfuture work:
Closes INS-4397