Skip to content

fix(cli): failed to run script in cli if timeline dir is not inited#8232

Merged
ihexxa merged 1 commit into
release/10.2.1-beta.1from
fix/cli/miss-timeline-dir
Dec 5, 2024
Merged

fix(cli): failed to run script in cli if timeline dir is not inited#8232
ihexxa merged 1 commit into
release/10.2.1-beta.1from
fix/cli/miss-timeline-dir

Conversation

@ihexxa
Copy link
Copy Markdown
Contributor

@ihexxa ihexxa commented Dec 5, 2024

Changes:

  • Init the path for persisting timeline file before executing script
  • Updated smoke tests

Ref: INS-4774

@ihexxa ihexxa self-assigned this Dec 5, 2024
@ihexxa ihexxa force-pushed the fix/cli/miss-timeline-dir branch from 725ac24 to 15e9872 Compare December 5, 2024 06:30
@ihexxa ihexxa changed the base branch from develop to release/10.2.1-beta.1 December 5, 2024 06:42
@ihexxa ihexxa force-pushed the fix/cli/miss-timeline-dir branch from 15e9872 to 8ad70cc Compare December 5, 2024 06:43
@ihexxa ihexxa requested a review from a team December 5, 2024 06:57
Copy link
Copy Markdown
Contributor

@notjaywu notjaywu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ihexxa ihexxa merged commit d1e39fd into release/10.2.1-beta.1 Dec 5, 2024
@ihexxa ihexxa deleted the fix/cli/miss-timeline-dir branch December 5, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants