feat(grpc): skip TLS when verification disabled + mTLS capability [INS-4536] - #8235
Merged
Conversation
ryan-willis
force-pushed
the
grpc-certs
branch
from
December 5, 2024 22:24
32c38c9 to
2cda9b0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1
to
+2
| -----BEGIN PRIVATE KEY----- | ||
| MIIEvwIBADANBgkqhkiG9w0BAQEFAASCBKkwggSlAgEAAoIBAQCR168bywxvB+VU |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: generic.secrets.security.detected-private-key.detected-private-key
ryan-willis
changed the title
ryan-willis
force-pushed
the
grpc-certs
branch
from
December 6, 2024 17:59
2cda9b0 to
7d29067
Compare
ryan-willis
force-pushed
the
grpc-certs
branch
from
December 6, 2024 18:17
7d29067 to
d363710
Compare
ryan-willis
marked this pull request as ready for review
December 6, 2024 19:23
filfreire
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes pr#8002
and should fix the issue seen in #6267