feat: minimal bar-[INS-4420]#8293
Merged
Merged
Conversation
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
January 14, 2025 02:45
aaf06b2 to
297d8cf
Compare
CurryYangxx
marked this pull request as draft
January 14, 2025 02:45
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
January 15, 2025 10:14
432ec04 to
2eac655
Compare
notjaywu
marked this pull request as ready for review
January 17, 2025 01:02
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
January 22, 2025 02:12
2eac655 to
9af5816
Compare
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
February 12, 2025 03:16
9af5816 to
16f9ad0
Compare
Contributor
|
Nit: User email is truncated when in smaller width window. Default: Minimal Bar: |
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
February 13, 2025 02:26
9c9ab49 to
6ccddfe
Compare
yaoweiprc
reviewed
Feb 13, 2025
| )} | ||
| </div> | ||
| {!isMinimal && ( | ||
| <div className="flex gap-[--padding-sm] items-center justify-end p-2"> |
Contributor
There was a problem hiding this comment.
I think we should extract the invite button and user button to standalone components here.
Member
Author
@cwangsmv Good catch! I updated style, when there is not enough space, the middle column will be compressed. |
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
February 13, 2025 06:11
ac9375b to
5c0f9cb
Compare
yaoweiprc
previously approved these changes
Feb 13, 2025
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
February 17, 2025 06:11
2480ffd to
b445fc1
Compare
CurryYangxx
enabled auto-merge (squash)
February 17, 2025 06:11
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
February 17, 2025 06:23
b445fc1 to
b65a6b3
Compare
CurryYangxx
force-pushed
the
feat/minimal-bar
branch
from
February 17, 2025 06:41
57cab7a to
87bc610
Compare
CurryYangxx
disabled auto-merge
February 17, 2025 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
isMinimalstate to control different UIScreen.Recording.2025-01-15.at.18.02.16.mov