fix(sdk): misc fixes and improvements#8297
Merged
Conversation
ihexxa
changed the title
CurryYangxx
reviewed
Jan 15, 2025
| }; | ||
|
|
||
| set = (variableName: string, variableValue: boolean | number | string) => { | ||
| if (variableValue === null) { |
Member
There was a problem hiding this comment.
The varaibleValue seems inconsistent with the type definition.
Contributor
Author
There was a problem hiding this comment.
Good catch, updated.
CurryYangxx
reviewed
Jan 15, 2025
| // TODO: support replacing substitution | ||
| printLog = (rows: Row[], level: LogLevel, ...values: any) => { | ||
| try { | ||
| const content = values.map((a: any) => JSON.stringify(a, null, 2).replace('\\n', '\n')) |
Contributor
Author
There was a problem hiding this comment.
JSON.stringify may transform \n into \\n in a (if it is a string).
ihexxa
changed the title
CurryYangxx
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also with some minor fixes.
Changes
\nand print params in one line (instead of multiple lines)nullto environmentMultipart body
log output
In test, actual got value is 200, and expected value is a long string.
Ref: INS-4795, #8240