Rename local-storage to electron-storage#8310
Merged
Merged
Conversation
CurryYangxx
approved these changes
Jan 22, 2025
ryan-willis
approved these changes
Jan 22, 2025
jackkav
force-pushed
the
rename-localstorage-to-avoid-confusion
branch
from
57acc09 to
3ba4336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Currently, we have a
local-storage.tsfile used to persistent data in local file.Since the name is confused with browser native
localStoragein render process, rename it to electron-storage to make it more clear.After this change,
localStoragepoints to the browser native localStorage in render process.electron-storageis the persistent storage to save data in local files in main process