Improve WSDL import [INS-4291]#8314
Merged
Merged
Conversation
yaoweiprc
marked this pull request as draft
January 23, 2025 05:29
yaoweiprc
changed the title
yaoweiprc
force-pushed
the
feat/flatten-wsdl-when-importing
branch
from
February 6, 2025 02:09
9d27bf6 to
e5d5426
Compare
yaoweiprc
force-pushed
the
feat/flatten-wsdl-when-importing
branch
5 times, most recently
from
March 4, 2025 09:58
a0ad1f1 to
170502a
Compare
yaoweiprc
force-pushed
the
feat/flatten-wsdl-when-importing
branch
3 times, most recently
from
March 27, 2025 10:15
e1891fb to
c2d4964
Compare
yaoweiprc
marked this pull request as ready for review
March 27, 2025 10:48
yaoweiprc
changed the title
yaoweiprc
force-pushed
the
feat/flatten-wsdl-when-importing
branch
2 times, most recently
from
April 16, 2025 03:51
28e1b0a to
d922d1b
Compare
CurryYangxx
reviewed
Apr 17, 2025
Member
|
I'd suggest adding a readme file in |
…hich reference other xsd files. Patch the npm package apiconnect-wsdl to remove the limits for generating SOAP request samples.
yaoweiprc
force-pushed
the
feat/flatten-wsdl-when-importing
branch
from
April 17, 2025 07:57
d922d1b to
b6bac47
Compare
CurryYangxx
approved these changes
Apr 17, 2025
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
Improve WSDL import * Use the feature of apiconnect-wsdl library to import the wsdl files which reference other xsd files. Patch the npm package apiconnect-wsdl to remove the limits for generating SOAP request samples. * show detailed error for each convertor when importing, remove unused generic type * fix review issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing WSDL files, the file may depend on other XSD files. We haven't parsed referenced XSD files before.
Now we pass the file path of the WSDL to apiconnect-wsdl to let it parse all referenced xsd files.
Also, there are restrictions that prevent it from generating a full sample request. It's hard-coded in apiconnect-wsdl, so we use patch-package to patch the files in apiconnect-wsdl to remove the restrictions
https://www.npmjs.com/package/patch-package
Finally, I added the logic to show the detailed error message within the importer as our customer requested.