make runners conventional#8325
Merged
Merged
Conversation
filfreire
previously approved these changes
Jan 28, 2025
filfreire
approved these changes
Jan 28, 2025
hexchain
reviewed
Jan 28, 2025
|
|
||
| # See https://github.com/electron/electron/issues/42510#issuecomment-2171583086 | ||
| - if: ${{ runner.os == 'Linux' }} | ||
| name: Lift unprivileged user namespace restrictions |
Contributor
There was a problem hiding this comment.
Not sure why the playwright smoke test job fails. You may try adding DEBUG=pw:browser* to debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moves macos from 13 to 14
ensures test and builds all use ubuntu 24 rather than a mix of 22 and 24
ubuntu-latest-arm might not exist as an alias