Skip to content

Conversation

@ryan-willis
Copy link
Contributor

@ryan-willis ryan-willis commented Jan 28, 2025

resolves: INS-4850

  • always show the Headers tab in the gRPC request pane in order to send custom headers with the reflection requests (closes Cannot specify headers for gRPC server reflection #6865)
  • combines the headers from the ancestors into the gRPC metadata (also applies to reflection)
  • in addition to filtering out disabled headers from gRPC metadata, removes ones that would throw errors (header keys with an empty name)

Opted to keep the "gathering" code localized to the pane since we're doing a whole lot in there already, but I'd like to move a good portion of the code in here into the loader (if feasible) in the future.

Intentionally did not surface validation errors (empty metadata/header keys) in the editor because (I believe) it'll be apparent enough to users visually that empty headers will not be sent

@ryan-willis ryan-willis changed the title fix: support headers with gRPC + reflection fix: support headers as metadata with gRPC + reflection Jan 28, 2025
@ryan-willis ryan-willis merged commit e3a399f into Kong:develop Jan 28, 2025
9 checks passed
@ryan-willis ryan-willis deleted the fix/grpc-headers branch February 17, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot specify headers for gRPC server reflection

2 participants