fix: .deb and .snap upload on publish [no-ticket]#8332
Merged
filfreire merged 2 commits intoJan 29, 2025
Conversation
gatzjames
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The architecture on electron-builder config adopts slightly different flavour for the file descriptors:
x64x86_64amd64This caused the
release-publishto fail because it was trying to grab a file that does not exist.This also removes the step where we try to upload arm64.snap - which we are not producing on release-build at the moment, hence the job would fail.
Note: the previous .deb (which is downloadable via API) needs to account for the new
_amd64- we will need to work on creating different download links (and buttons on insomnia-website)