Skip to content

Prettify json in response viewer [INS-4966]#8354

Merged
yaoweiprc merged 1 commit into
developfrom
feat/not-escape-forward-slash-in-preview
Feb 14, 2025
Merged

Prettify json in response viewer [INS-4966]#8354
yaoweiprc merged 1 commit into
developfrom
feat/not-escape-forward-slash-in-preview

Conversation

@yaoweiprc
Copy link
Copy Markdown
Contributor

@yaoweiprc yaoweiprc commented Feb 11, 2025 •
edited
Loading

Close #1556

  1. Use native method JSON.stringify to prettify json before it's passed to CodeEditor, which can solve the problem of forward slash escape mentioned in the issue.
  2. Use useCallback hook to wrap functions in ResponseViewer component, to avoid creating new functions every time the component renders.

@yaoweiprc yaoweiprc force-pushed the feat/not-escape-forward-slash-in-preview branch from e987804 to 6a6a5b6 Compare February 11, 2025 12:49
CurryYangxx
CurryYangxx reviewed Feb 12, 2025
View reviewed changes
Comment thread packages/insomnia/src/ui/components/viewers/response-viewer.tsx
@yaoweiprc yaoweiprc force-pushed the feat/not-escape-forward-slash-in-preview branch from 6a6a5b6 to fe2ef3b Compare February 13, 2025 13:57
@yaoweiprc yaoweiprc force-pushed the feat/not-escape-forward-slash-in-preview branch from fe2ef3b to a0cfa86 Compare February 14, 2025 06:41
@yaoweiprc yaoweiprc merged commit 01b8089 into develop Feb 14, 2025
@yaoweiprc yaoweiprc deleted the feat/not-escape-forward-slash-in-preview branch February 14, 2025 07:06
pavkout pushed a commit to pavkout/insomnia that referenced this pull request Feb 17, 2025
@yaoweiprc @pavkout
Use native way to prettify json in response viewer (Kong#8354)
dd57049
@yaoweiprc yaoweiprc mentioned this pull request May 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurryYangxx CurryYangxx CurryYangxx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Friendlier JSON in Preview mode

2 participants

@yaoweiprc @CurryYangxx