Short-ciruit string rendering if require invocation is detected#8358
Merged
Conversation
jackkav
force-pushed
the
fix/nunjucks-stop-require
branch
from
a548ed6 to
fe5ff80
Compare
jackkav
approved these changes
Feb 12, 2025
pavkout
pushed a commit
to pavkout/insomnia
that referenced
this pull request
Feb 17, 2025
…#8358) * Short-ciruit string rendering if require invocation is detected [SEC-1323] [INS-4963] * add sentry exception --------- Co-authored-by: jackkav <jackkav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a temporary means of preventing string rendering if a require invocation is detected. This has been tested locally and verified to be functional (enough) against strings in the URL, body, and headers but should cover all flows which render strings with the exception of ones introduced via plugins.
Closes SEC-1323