fix: Escape key closes environment editor modal in vim mode [INS-4975] - #8368
Merged
Conversation
pavkout
force-pushed
the
feature/ins-4975
branch
from
February 13, 2025 12:04
0b5db60 to
f100236
Compare
marckong
approved these changes
Feb 13, 2025
filfreire
approved these changes
Feb 14, 2025
… on keymap settings
filfreire
force-pushed
the
feature/ins-4975
branch
from
February 14, 2025 13:50
f100236 to
1233367
Compare
filfreire
enabled auto-merge (squash)
February 14, 2025 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent CodeMirror from capturing escape key and shortcuts based on keymap settings
Closes INS-4975, 4877