Chore: Fix vault case failure and add one more test for vault key#8378
Merged
Chore: Fix vault case failure and add one more test for vault key#8378
Conversation
cwangsmv
force-pushed
the
fix/secret-item-switch-issue
branch
from
67e0dd4 to
ffad65d
Compare
cwangsmv
changed the title
gatzjames
approved these changes
Feb 19, 2025
gatzjames
reviewed
Feb 19, 2025
| const expectedVaultKeyValue = 'eyJhbGciOiJBMjU2R0NNIiwiZXh0Ijp0cnVlLCJrIjoia'; | ||
| const vaultKeyValue = await page.getByTestId('VaultKeyDisplayPanel').innerText(); | ||
| await expect(vaultKeyValue).toContain(expectedVaultKeyValue); | ||
| await page.getByTitle('Copy Vault Key').click(); |
Contributor
There was a problem hiding this comment.
Are there other ways for this check without using the clipboard api?
filfreire
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: