Solve the bug related to importing multiple workspaces in one file [INS-5077]#8442
Merged
Conversation
yaoweiprc
changed the title
yaoweiprc
changed the title
yaoweiprc
force-pushed
the
fix/import-error
branch
2 times, most recently
from
4f6b3e3 to
032c079
Compare
ryan-willis
previously approved these changes
Mar 13, 2025
ryan-willis
left a comment
ryan-willis
left a comment
Contributor
There was a problem hiding this comment.
the filtering/traversal code is a bit if a brain teaser, but I trust you
CurryYangxx
reviewed
Mar 14, 2025
filfreire
previously approved these changes
Mar 14, 2025
gatzjames
reviewed
Mar 14, 2025
yaoweiprc
force-pushed
the
fix/import-error
branch
2 times, most recently
from
ca4e22f to
95fd57b
Compare
gatzjames
approved these changes
Mar 18, 2025
yaoweiprc
force-pushed
the
fix/import-error
branch
from
95fd57b to
bd516ce
Compare
…ere are multiple workspaces in one imported file
Co-authored-by: James Gatz <jamesgatzos@gmail.com>
yaoweiprc
force-pushed
the
fix/import-error
branch
from
bd516ce to
5049ee8
Compare
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
…NS-5077] (#8442) * Solve the bug that it imports all resources to all workspaces when there are multiple workspaces in one imported file * add smoke test * Apply suggestions from code review Co-authored-by: James Gatz <jamesgatzos@gmail.com> * Use import-from-clipboard instead of import-from-file in smoke test --------- Co-authored-by: James Gatz <jamesgatzos@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #8424
If the user imports a file containing more than one workspace, we create a new workspace for each workspace in the file. Then, all resources in the file are added to all newly created workspaces, regardless of whether they belong to the workspace.
That is why the 'Error: New Requests missing parentId' showed up.
Now we check whether a resource belongs to a workspace before it's added to the workspace.