fix: Set native menus per-window#8444
Merged
Merged
Conversation
|
|
Previously when a new window was created `Menu.setApplicationMenu()` was called, which would change all windows' native menu to the newly created one - causing every window menu to reference the newly created `BrowserWindow`. Now each window is set their own `Menu` instance which will have their own `BrowserWindow`.
Contributor
|
Thank you for submitting the PR. You have a deep understanding of Electron. I believe this PR can fix more hidden issues. @Stedoss |
yaoweiprc
approved these changes
Mar 24, 2025
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
Previously when a new window was created `Menu.setApplicationMenu()` was called, which would change all windows' native menu to the newly created one - causing every window menu to reference the newly created `BrowserWindow`. Now each window is set their own `Menu` instance which will have their own `BrowserWindow`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8399.
Previously when a new window was created
Menu.setApplicationMenu()was called, which would change all windows' native menu to the newly created one - causing every window menu to reference the newly createdBrowserWindow. This causes weird behaviour with old windows (seeBeforevideo).Now each window is set their own
Menuinstance which will have their ownBrowserWindow.Note
This mostly impacts Windows and Linux, may need some testing on Mac to make sure behaviour is still as expected.
Before
electron_yApfFkBxZg.mp4
After
iPiHNTZGTX.mp4