securely wrap execution - #8451
Merged
Merged
Conversation
ryan-willis
force-pushed
the
sec/securely-wrap-execution
branch
from
March 15, 2025 02:30
8ba2f72 to
ba928b2
Compare
ryan-willis
marked this pull request as ready for review
March 15, 2025 02:58
marckong
approved these changes
Mar 24, 2025
marckong
left a comment
marckong
left a comment
Contributor
There was a problem hiding this comment.
LGTM. We tested it together in a call and the fix seems to behave as expected.
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
* test using a wrapper that sets security context before invoking the main application * add build step to pr ci * try with diff ver string * statically link the standard libraries for portability * more static linking * prior version string * remove pr substring from version * try using a different version string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves INS-5048
what this does:
insomnia.dll(so that it can be code-signed)Insomnia.exe(also code-signed)insomnia.dllcalledinsomnia-$VERSION.exeand executes it with custom Windows process mitigation policiesinsomnia-$VERSION.exefilethis is meant to be a stop-gap for CVE-2025-1353 and will very likely be superseded by other measures (NSIS/MSI installing into protected directories, etc)
to test locally, run
./build-secure-wrapper.shfrom a bash-like shell on Windows with MSYS2/MinGW installed, then runpackages/insomnia/dist/squirrel-windows/Insomnia.Core-X.X.X.exeto install Insomnia.everything should run normally when launching/installing/uninstalling
this installer launches cleanly on a fresh Windows 11 as well
references:
https://chromium.googlesource.com/chromium/src.git/+/master/docs/security/faq.md#why-arent-physically_local-attacks-in-chromes-threat-model
https://learn.microsoft.com/en-us/windows/security/threat-protection/overview-of-threat-mitigations-in-windows-10#table-4functions-available-to-developers-for-building-mitigations-into-apps