Add typing for templating context#8455
Merged
Merged
Conversation
jackkav
force-pushed
the
typing-plugin-context
branch
from
March 13, 2025 14:51
a6d1bd2 to
2cc7fd8
Compare
jackkav
force-pushed
the
typing-plugin-context
branch
4 times, most recently
from
March 18, 2025 08:50
c06ee1f to
eefa533
Compare
jackkav
marked this pull request as ready for review
March 18, 2025 08:50
jackkav
force-pushed
the
typing-plugin-context
branch
from
March 18, 2025 09:06
eefa533 to
b9aaca7
Compare
jackkav
force-pushed
the
typing-plugin-context
branch
from
March 18, 2025 12:18
0eec749 to
8e1990f
Compare
filfreire
approved these changes
Mar 18, 2025
cwangsmv
reviewed
Mar 18, 2025
|
|
||
| export type NunjucksTagContextMenuAction = 'edit' | 'delete'; | ||
|
|
||
| export interface nunjucksTagContextMenuOptions extends Exclude<ReturnType<typeof extractNunjucksTagFromCoords>, void> { |
Contributor
There was a problem hiding this comment.
Nit: This interface does not follow PascalCase while other interfaces/types do
cwangsmv
approved these changes
Mar 18, 2025
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo
in order to iterate on the web worker renderer and improve extensibility, we want move types into one file in order to avoid importing the mixed context db code into the worker and causing a call stack exception
in this PR im aiming to take a second pass at the worker with a focus on making the types stricter
getBodyBuffer was previously a syncronous function meaning it was not a promise and that meant react code didn't need to wait for it to execute or handle it in any special way during re-renders, since we need to promisify and serialise all calls to the plugin api we're now going to need this to be an async function which might have some side effects in the response pane rendering code TBD
related: INS-4963