fix: Fixed cookie modal issue [INS-5210] - #8508
Merged
Merged
Conversation
pavkout
force-pushed
the
feature/ins-5210
branch
from
March 22, 2025 22:26
b3bf7ca to
7424fb2
Compare
pavkout
changed the title
CurryYangxx
reviewed
Mar 24, 2025
| @@ -107,7 +97,16 @@ export const CookiesModal = ({ setIsOpen }: Props) => { | |||
|
|
|||
| const handleAddCookie = () => { | |||
| const updatedActiveCookieJar = activeCookieJar; | |||
Member
There was a problem hiding this comment.
const updatedActiveCookieJar = {...activeCookieJar};
It would be better to copy the origin object data first rather than modify props directly.
Contributor
Author
There was a problem hiding this comment.
@CurryYangxx Yes, we can do it. Let's do it in a separate PR and check all the places we need to change.
pavkout
force-pushed
the
feature/ins-5210
branch
from
March 24, 2025 11:02
7424fb2 to
d8e93e4
Compare
pavkout
force-pushed
the
feature/ins-5210
branch
from
March 24, 2025 11:19
d8e93e4 to
b6d4f9c
Compare
gatzjames
approved these changes
Mar 24, 2025
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes INS-5210, 8507