Skip to content

Refactor-plugins-apps - #8521

Merged
jackkav merged 7 commits into
Kong:developfrom
jackkav:refactor-plugins-apps
Mar 25, 2025
Merged

Refactor-plugins-apps#8521
jackkav merged 7 commits into
Kong:developfrom
jackkav:refactor-plugins-apps

Conversation

@jackkav

@jackkav jackkav commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

In order to make plugins runnable from electron main we first want to refactor the renderer code to make an api surface that will match something that could be polymorphic

ideas

  • strip extra code from app.tsx
  • build a similar api surface that could work in electron main
  • identify and agree on changes to existing implementation, eg Adding HTML wrapper to dialog
  • decide which is better for now polymorphic app.tsx, or worker fork separation

Ref: INS-5702

@jackkav
jackkav force-pushed the refactor-plugins-apps branch from 5c7b3ff to a8d6d10 Compare March 25, 2025 13:40
@jackkav
jackkav requested a review from a team March 25, 2025 14:12
@jackkav
jackkav merged commit 8fa27fc into Kong:develop Mar 25, 2025
@jackkav
jackkav deleted the refactor-plugins-apps branch March 25, 2025 15:58
cwangsmv pushed a commit that referenced this pull request Apr 21, 2025
* first pass

* remove depreacted method

* second pass clean up

* split plugin app main and renderer

* move into worker

* typing

---------

Co-authored-by: Ryan Willis <ryan.willis@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants