fix: secure wrapper when paths contain utf-16 characters#8539
Merged
Conversation
ryan-willis
force-pushed
the
doc/secure-wrapper
branch
from
46152e6 to
a7a7571
Compare
ryan-willis
changed the title
ryan-willis
force-pushed
the
doc/secure-wrapper
branch
2 times, most recently
from
66d0eb0 to
60dc988
Compare
ryan-willis
force-pushed
the
doc/secure-wrapper
branch
from
60dc988 to
59412a8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a secure wrapper update that addresses vulnerabilities related to local search paths, specifically improving support for multi-byte unicode strings and paths with spaces.
- Refactors the wrapper to support UTF-16 and multi-byte unicode in paths.
- Fixes issues with shortcut operations by handling spaces in paths.
- Adds build instructions and a clang-format rule for consistency.
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/insomnia/src/cpp/README.md | Adds documentation for building and using the secure wrapper. |
| .clang-format | Introduces a ColumnLimit setting to enforce code formatting. |
Files not reviewed (4)
- build-secure-wrapper.sh: Language not supported
- packages/insomnia/src/cpp/insomnia.cpp: Language not supported
- packages/insomnia/src/cpp/manifest.txt: Language not supported
- packages/insomnia/src/cpp/resources.rc: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gatzjames
approved these changes
Mar 31, 2025
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
* fix wrapper * doc: add notes and build instructions for the wrapper * wrap application name when calling CreateProcessW * make executable squirrel-aware * quote paths if they contain a space * fix quoted shortcuts * Update packages/insomnia/src/cpp/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial solution for #8537