Skip to content

fix(Git Sync): discard changes should delete requests and other entities if they don't exist in the previous version#8551

Merged
gatzjames merged 1 commit into
Kong:developfrom
gatzjames:fix/git-sync-undo-changes
Mar 31, 2025
Merged

fix(Git Sync): discard changes should delete requests and other entities if they don't exist in the previous version#8551
gatzjames merged 1 commit into
Kong:developfrom
gatzjames:fix/git-sync-undo-changes

Conversation

@gatzjames

@gatzjames gatzjames commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

The issue:

Inside a Git Project, when a user creates a request in a file and then discards the changes that have been made in that file, any entities e.g. new request that were created are not properly removed from the db.
This means that a user will chose to discard changes but those changes will persist.

Highlights:

  • When git updates a file we clean the previous workspace and it's descendants and use the resources provided by that version of the file.

Closes INS-5245

@gatzjames gatzjames requested a review from a team March 31, 2025 10:30
@gatzjames gatzjames self-assigned this Mar 31, 2025

@pavkout pavkout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatzjames gatzjames merged commit 8d898da into Kong:develop Mar 31, 2025
@gatzjames gatzjames deleted the fix/git-sync-undo-changes branch March 31, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants