Prettier pass 3 - #8586
Merged
Merged
Conversation
jackkav
force-pushed
the
prettier-pass-3
branch
2 times, most recently
from
April 9, 2025 17:32
b5df47d to
263b211
Compare
jackkav
marked this pull request as ready for review
April 9, 2025 17:33
jackkav
force-pushed
the
prettier-pass-3
branch
from
April 10, 2025 12:17
bb4ce74 to
263b211
Compare
pavkout
approved these changes
Apr 11, 2025
jackkav
force-pushed
the
prettier-pass-3
branch
from
April 11, 2025 11:11
263b211 to
f296c99
Compare
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
* first pass * use mjs * 120 * single quote * consistent quotes * fix on save * ancestors * add recommended * make vscode integration work * remove prettier runtime dep * use esm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been suggested to follow an all in one approach. @ihexxa
I intend to first merge this then immediately open a second pr with the full autoformat to make rebasing a little easier.
closes: INS-5291
update:
prettier 3.5.3 is causing a OOM in the renderer so I'm switching it out for prettier-graphql which is much lighter solution and since its dep free i've chosen to import the code directly as mjs to avoid typing it as gql types are notorious. This might have bundling consequences, will wait for CI to tell us.