fix inso script not reading config#8600
Merged
Merged
Conversation
ihexxa
approved these changes
Apr 10, 2025
ihexxa
left a comment
ihexxa
left a comment
Contributor
There was a problem hiding this comment.
Double check: do we still allow overriding option?
jackkav
force-pushed
the
fix-inso-script
branch
from
4313b4e to
6a60a9f
Compare
cwangsmv
pushed a commit
that referenced
this pull request
Apr 21, 2025
* fix script * optional chain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a mistake that occurred while refactoring the cli to improve developer experience and add request scripting features.
inso script was reading the
.insorcinto an objectbut searching in the wrong object for the values
Also added debug logging
fixes: INS-5290