Skip to content

refactor(sdk): only display error message without stacktrace for minor errors#8606

Merged
jackkav merged 3 commits into
developfrom
refactor/sdk/error
Apr 24, 2025
Merged

refactor(sdk): only display error message without stacktrace for minor errors#8606
jackkav merged 3 commits into
developfrom
refactor/sdk/error

Conversation

@ihexxa
Copy link
Copy Markdown
Contributor

@ihexxa ihexxa commented Apr 14, 2025

Change

  • Throw a string message instead an error -- Originally I introduced a custom error to do this, but after discussed within team, we plan to avoid introducing error abstraction too early.
  • Reformat outputs into message and stack.

Without stack:
image

With stack:
image

@ihexxa ihexxa self-assigned this Apr 14, 2025
@ihexxa ihexxa marked this pull request as draft April 14, 2025 08:31
Comment thread packages/insomnia-scripting-environment/src/objects/environments.ts Outdated
@ihexxa ihexxa force-pushed the refactor/sdk/error branch 2 times, most recently from 24e66d6 to 5beb5bc Compare April 23, 2025 09:15
@ihexxa ihexxa force-pushed the refactor/sdk/error branch from 5beb5bc to 5424cf3 Compare April 24, 2025 02:36
@ihexxa ihexxa marked this pull request as ready for review April 24, 2025 06:19
@jackkav jackkav merged commit 7b5cddb into develop Apr 24, 2025
10 checks passed
@jackkav jackkav deleted the refactor/sdk/error branch April 24, 2025 06:46
cwangsmv pushed a commit that referenced this pull request Apr 25, 2025
…r errors (#8606)

* refactor(sdk): only display error message without stacktrace for minor errors

* chore: comments

* refactor: use string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants