chore(publish): publish releases - #8648
Merged
Merged
Conversation
notjaywu
force-pushed
the
chore/publish-releases
branch
from
April 25, 2025 08:11
7401ded to
bc4e68b
Compare
notjaywu
changed the title
notjaywu
marked this pull request as ready for review
April 25, 2025 08:13
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the release publishing workflow by eliminating the legacy artifact downloader and artifact uploader actions and instead leverages the GitHub CLI for release verification, asset download, and release editing.
- Removed the robinraju/release-downloader action and its associated steps.
- Added a check to verify if the release exists and download its assets using the gh CLI.
- Replaced the tag/release and artifact upload steps with a unified "Publish release" step via gh release edit.
Comments suppressed due to low confidence (2)
.github/workflows/release-publish.yml:141
- [nitpick] Consider aligning the token environment variable name with previous steps (e.g. using 'GITHUB_TOKEN') for consistency and clarity across the workflow.
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
.github/workflows/release-publish.yml:133
- The new 'Publish release' step no longer handles artifact uploads, which were previously performed by the release upload step. Please verify that this change is intentional and that artifact uploading is not required.
- name: Publish release
balugeorge
approved these changes
Apr 28, 2025
notjaywu
force-pushed
the
chore/publish-releases
branch
from
April 28, 2025 06:45
bc4e68b to
32150db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.