Skip to content

refactor: default hide the swagger preview#8660

Merged
marckong merged 2 commits into
developfrom
INS-5434
May 14, 2025
Merged

refactor: default hide the swagger preview#8660
marckong merged 2 commits into
developfrom
INS-5434

Conversation

@marckong

@marckong marckong commented Apr 29, 2025

Copy link
Copy Markdown
Contributor
  • we want to hide the swagger panel by default until enabled

@gatzjames gatzjames left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the Preview feature will be discoverable by new users if we default to disabling it in all cases.
Maybe we should display the Preview when there is a spec available

Comment thread packages/insomnia/src/ui/routes/design.tsx Outdated
@godfrzero

Copy link
Copy Markdown
Contributor

Not sure if the Preview feature will be discoverable by new users if we default to disabling it in all cases. Maybe we should display the Preview when there is a spec available

Yes, let's only hide the Preview by default if there's no specification to render. There is, of course, a discoverability problem we need to address but we can pick that up as a separate item.

@marckong
marckong requested a review from gatzjames May 12, 2025 15:08
@marckong
marckong requested a review from a team May 12, 2025 16:22
@marckong
marckong merged commit 83b3661 into develop May 14, 2025
@marckong
marckong deleted the INS-5434 branch May 14, 2025 16:03
cwangsmv pushed a commit that referenced this pull request Jun 10, 2025
* refactor: default hide the swagger preview

* Update packages/insomnia/src/ui/routes/design.tsx

Co-authored-by: James Gatz <jamesgatzos@gmail.com>

---------

Co-authored-by: James Gatz <jamesgatzos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants