Fix smoke test flaky cases in slower runners#8665
Merged
Merged
Conversation
ZxBing0066
previously approved these changes
Apr 30, 2025
| await page.getByLabel('Create in collection').click(); | ||
| await page.getByLabel('HTTP Request').click(); | ||
| // check new request created | ||
| await page.getByTestId('New Request').isVisible(); |
Member
There was a problem hiding this comment.
Just curious about this line, as I know page.getByTestId('New Request') will wait for the element to exist, why do we need to use isVisible() here? Is there anything that causes the element to be created but cannot be clicked? 🤔
Contributor
Author
There was a problem hiding this comment.
From the trace file screenshot,await page.getByTestId('New Request').dblclick(); clicks on the wrong element. So add a isVisible first to ensure that the newly created element appears on UI before double click.
cwangsmv
force-pushed
the
fix/e2e-flaky-case-in-slow-runners
branch
from
9d744bb to
966eb67
Compare
ZxBing0066
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix flaky smoke test cases, especially in slower runner.