fix: domain in cookie list not update when be set to empty#8683
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the cookie's Domain field does not update when set to an empty value.
- Resets the RenderedTextInternal state when children is falsy to correctly update the cookie domain display.
- Adds a data-testid attribute to the cookie domain element in the cookies modal.
- Introduces new smoke tests to verify the cookie update behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/insomnia/src/ui/components/rendered-text.tsx | Resets renderedText and error state when no children are provided, ensuring that an empty domain is correctly rendered. |
| packages/insomnia/src/ui/components/modals/cookies-modal.tsx | Adds a data-testid attribute to the span wrapping the RenderedText component to facilitate targeted testing. |
| packages/insomnia-smoke-test/tests/smoke/cookie-editor-interactions.test.ts | Adds new tests to verify that setting a cookie domain to empty and reassigning it correctly updates the UI. |
cwangsmv
approved these changes
May 7, 2025
cwangsmv
pushed a commit
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
INS-5474
The Domain in the cookie list is not updated when it's set to empty
Kapture.2025-05-07.at.13.23.10.mp4
Changes
renderedTextstate to empty in RenderedTextInternal when children is a false value