Fix: rendering in worker error bug [INS-5482] - #8695
Merged
Conversation
jackkav
approved these changes
May 13, 2025
cwangsmv
force-pushed
the
fix/worker-templating-render-error-issue
branch
from
May 13, 2025 09:42
a15eeaa to
31ef809
Compare
cwangsmv
enabled auto-merge (squash)
May 13, 2025 09:42
cwangsmv
added a commit
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using a environment variable with a invalid nunjck tag in OAuth:
Expected error message that shoud displayed
Actually result when click Fetch Tokens
Changes
The
templating-handleris initialized RenderError with the error object, which should be the string type of error message content.So components using the
err.messageto render will throw unexpected React child error.Change to initialize RenderError with err.message instead. Also add path and location attribute if exists