fix: specify bash as shell to ensure INSO_VERSION can be read on Windows - #8704
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue on Windows where the inso CLI was returning an incorrect version by explicitly specifying bash as the shell when setting the INSO_VERSION environment variable.
- Enforces the use of bash in the "Setup Inso CLI version env var" step to ensure consistent behavior on Windows.
Comments suppressed due to low confidence (1)
.github/workflows/release-build.yml:71
- [nitpick] Ensure that the bash shell is available on all runners, particularly if this workflow may run on Windows self-hosted machines. You might consider adding documentation or a check to verify bash availability.
shell: bash
Member
Author
|
It works when running on my fork repo. https://github.com/ZxBing0066/insomnia/actions/runs/14969221562/job/42046322618#step:9:7 |
ihexxa
approved these changes
May 12, 2025
ZxBing0066
enabled auto-merge (squash)
May 13, 2025 02:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When users use the inso CLI on Windows, it returns
devas its version.Root Cause
From the log, the version cannot be read on Windows when building.
Windows uses PowerShell as the default shell, it needs a different expression to set the env, so specify it to use bash to avoid the inconsistency.
Changes
Specify bash as the shell when
Setup Inso CLI version env var.Closes #8397