fix: preserve empty strings during export#8727
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes INS-5463 by preserving empty string environments during export. It removes the check that filtered out empty strings and introduces a new test to validate that empty strings are retained.
- Removed the empty string check in filterEmptyValue.
- Added a test case to validate the new behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/insomnia/src/common/insomnia-v5.ts | Updated filterEmptyValue to preserve empty strings. |
| packages/insomnia/src/common/tests/insomnia-v5.test.ts | Added test to ensure empty string environments are preserved. |
ZxBing0066
commented
May 19, 2025
ryan-willis
previously approved these changes
May 19, 2025
gatzjames
reviewed
May 21, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes INS-5463 by preserving empty string values during export to ensure environment templates render correctly.
- Removed empty string check in the filterEmptyValue function.
- Added a test case to validate that empty string environments are preserved.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/insomnia/src/common/insomnia-v5.ts | Removed filtering of empty strings in export logic. |
| packages/insomnia/src/common/tests/insomnia-v5.test.ts | Added a test case verifying empty strings are preserved. |
ihexxa
approved these changes
May 28, 2025
gatzjames
approved these changes
May 28, 2025
cwangsmv
pushed a commit
that referenced
this pull request
Jun 10, 2025
RoamingLost
pushed a commit
to RoamingLost/insomnia
that referenced
this pull request
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
INS-5463
Empty string environments are filtered out during export, which breaks the template render
Changes