Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height of the query preview box is not constrained for longer query strings #873

Merged

Conversation

@j-collier
Copy link
Contributor

j-collier commented Apr 20, 2018

Closes #869.

This is the most simple solution that does not have a negative impact on user experience in my test. With this simple CSS change the height of the query preview box appears as normal if empty and will automatically expand to fit the length of the query which is ideal for longer queries.

A more robust solution would allow the user to expand and shrink the box at will. However I don't feel that would be ideal for the user experience because it adds an extra moving part when the box can resize on it's own very easily and the container itself is scrollable.

@welcome

This comment has been minimized.

Copy link

welcome bot commented Apr 20, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@j-collier j-collier changed the title option one: height of the query preview box is not constrained Height of the query preview box is not constrained for longer query strings Apr 20, 2018
Copy link
Contributor

gschier left a comment

I'm fine with this change. Thanks @j-collier! 👍 ⚡️

@gschier gschier merged commit 2622cb1 into Kong:develop Apr 20, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Apr 20, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.