Skip to content

Chore(E2E): Remove arbitrary waits in e2e test#8746

Merged
cwangsmv merged 2 commits into
developfrom
kentfix/remove-arbitrary-wait-in-e2e
May 26, 2025
Merged

Chore(E2E): Remove arbitrary waits in e2e test#8746
cwangsmv merged 2 commits into
developfrom
kentfix/remove-arbitrary-wait-in-e2e

Conversation

@cwangsmv
Copy link
Copy Markdown
Contributor

@cwangsmv cwangsmv commented May 22, 2025

Changes

  • Add a delay for the click action to replace the arbitrary wait for editor debounce to take effect
  • Add expecting a change for new request tab/modal to appear rather than arbitrary waits

@cwangsmv cwangsmv marked this pull request as draft May 22, 2025 09:22
@cwangsmv cwangsmv marked this pull request as ready for review May 22, 2025 10:06
@cwangsmv cwangsmv requested review from gatzjames and jackkav May 22, 2025 10:06
Copy link
Copy Markdown
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheeky delay, but better

@cwangsmv cwangsmv force-pushed the kentfix/remove-arbitrary-wait-in-e2e branch from 1d935fe to 21eed87 Compare May 23, 2025 06:11
@cwangsmv cwangsmv enabled auto-merge (squash) May 23, 2025 06:12
@cwangsmv cwangsmv merged commit 3072a27 into develop May 26, 2025
10 checks passed
@cwangsmv cwangsmv deleted the kentfix/remove-arbitrary-wait-in-e2e branch May 26, 2025 02:17
cwangsmv added a commit that referenced this pull request Jun 10, 2025
* remove arbitrary wait for debounce
RoamingLost pushed a commit to RoamingLost/insomnia that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants