chore(analytics): capture abnormal run test events - INS-5623#8765
Merged
Conversation
ihexxa
force-pushed
the
chore/track-run-test
branch
from
9d73116 to
a4a5c70
Compare
ihexxa
changed the title
ihexxa
force-pushed
the
chore/track-run-test
branch
from
a4a5c70 to
0d3a499
Compare
ihexxa
force-pushed
the
chore/track-run-test
branch
from
0d3a499 to
e989097
Compare
ihexxa
force-pushed
the
chore/track-run-test
branch
from
ef7f851 to
75a6193
Compare
CurryYangxx
reviewed
Jun 16, 2025
| } catch (error: unknown) { | ||
| console.warn('[analytics] Unexpected error while sending segment event', error); | ||
| } finally { | ||
| if (!userSession?.hashedAccountId && [SegmentEvent.unitTestRun, SegmentEvent.unitTestRunAll].includes(event)) { |
Member
There was a problem hiding this comment.
Seems you just want to send a specific Sentry event here, but trackSegmentEvent is a common function.
I think it is better to report Sentry event directly in the corresponding action.
Contributor
Author
There was a problem hiding this comment.
Yes, this is added temporarily and finally we will remove this, or we may need to add several duplicated captures calls with some logic for getting session.
CurryYangxx
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes