JSON environment is not saved when json format becomes valid for the first time[INS-5894] - #8816
Merged
Merged
Conversation
gatzjames
approved these changes
Jun 27, 2025
cwangsmv
force-pushed
the
fix/environment-editor-save-issue
branch
from
June 30, 2025 02:01
d5de6f0 to
7f531c4
Compare
RoamingLost
pushed a commit
to RoamingLost/insomnia
that referenced
this pull request
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduce Step:
2.Insert a new row(Invalid JSON since comma is missing for the first line)
3.Add the missing comma and close the editor
4.The environment has not been saved
The root cause is that when json becomes valid for the first time, the isValid() ref still returns the false since error state is not updated yet.
Add a new ref to save the error message and isValid() ref will use the ref to detect if the json content is valid or not.