fix(Duplicate): Ensure id's match the request ids in the unit tests - #8833
Merged
Conversation
pavkout
approved these changes
Jul 7, 2025
When duplicating a workspace we now use the same functionality as import/export to have consistency on matching request ids and resources needed to be created
gatzjames
force-pushed
the
feature/ins-5236-link-from-test-to-request-broken-when-importing-to-project
branch
from
July 7, 2025 09:32
9346273 to
057d9e5
Compare
gatzjames
deleted the
feature/ins-5236-link-from-test-to-request-broken-when-importing-to-project
branch
July 7, 2025 10:01
RoamingLost
pushed a commit
to RoamingLost/insomnia
that referenced
this pull request
Aug 6, 2025
…ong#8833) * fix issue of request id matching when duplicating a workspace. When duplicating a workspace we now use the same functionality as import/export to have consistency on matching request ids and resources needed to be created * remove unused import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently when duplicating a workspace unit tests that point to a specific request end up with empty pointers since we don't map the new request ids to the new unit-tests being created.
This PR uses the same core functions that we use to import data to a new workspace that ensure the appropriate mapping is created along with other things that need to be setup.
Since we now use the same underlying functionality it also keeps the logic consistent and removes duplicate work.