fix: ensure oauth2 pkce method is sent when enabled [INS-837] - #8869
Merged
ryan-willis merged 3 commits intoJul 17, 2025
Merged
Conversation
ryan-willis
marked this pull request as ready for review
July 17, 2025 14:53
gatzjames
approved these changes
Jul 17, 2025
ryan-willis
enabled auto-merge (squash)
July 17, 2025 15:31
ryan-willis
deleted the
fix/oauth2-default-pkce-method-when-enabled-INS-837
branch
July 17, 2025 15:44
RoamingLost
pushed a commit
to RoamingLost/insomnia
that referenced
this pull request
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring either a request or a folder with OAuth 2.0, enabling PKCE does not immediately store the value for the PKCE method. The form displays
SHA-256, but the actual value on the item'sauthenticationobject isundefineduntil a user makes a selection from the dropdown.Due to the complexity surrounding the addition of an onChange hook to the
AuthToggleRowcomponent that would set the default value, and the fact that users may already have this broken state in their local db, I opted to narrow this change to thegetOAuth2Tokenmethod to chooseSHA-256as the PKCE method in the absence of a value when PKCE is enabled.