fix: closest folder auth determination logic [INS-638] - #8884
Merged
ryan-willis merged 2 commits intoJul 17, 2025
Conversation
marckong
approved these changes
Jul 17, 2025
RoamingLost
pushed a commit
to RoamingLost/insomnia
that referenced
this pull request
Aug 6, 2025
* fix: reverse folder priority when inheriting auth [INS-638] * fix: don't alter arrays in-place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When request groups (folders) for a request are fetched from the database using
withAncestors, the resulting array is sorted from highest level to lowest, so auth determinations will prioritize the highest if auth info is defined there.This change performs an non-destructive reverse on that list so that the first found folder with auth info is closer to the request itself.