Refactor plugin structure to avoid inso bundling UI logic - #8892
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| '. Please contact the plugin author sharing the below stack trace to help them to ensure compatibility with the latest Insomnia.', | ||
| error: err, | ||
| }); | ||
| console.error(`[plugin] Error while loading plugin from ${p}/${filename}:`, err); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring Note
jackkav
marked this pull request as ready for review
July 21, 2025 20:21
ryan-willis
previously approved these changes
Jul 21, 2025
jackkav
force-pushed
the
keep-inso-out-of-ui-code
branch
from
July 22, 2025 09:20
af57e8e to
e250c9e
Compare
jackkav
force-pushed
the
keep-inso-out-of-ui-code
branch
from
July 22, 2025 09:33
e250c9e to
cc29df0
Compare
gatzjames
approved these changes
Jul 22, 2025
RoamingLost
pushed a commit
to RoamingLost/insomnia
that referenced
this pull request
Aug 6, 2025
* extracting template functions to src * move all ui export logic into ui * remove modal from plugin init * remove har from plugin api * remove alert and prompt model shortcuts * replace renderPurpose with renderer check * split plugin barrel * fix test * use window to work around renderer imports * restore har api * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Prepares for renderer main separation by making it easier to identify which plugin contexts are used where.
Why: Because app context has imperative modal hooks which only work in the app, and only sometimes make the cli build fail.
Goal: exclude all react code from the inso bundle